feat: add callbacks for resample and benchmark #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebffischer
requested changes
Dec 2, 2024
|
mb706
reviewed
Dec 11, 2024
| tab = as.data.table(bmr, data_extra = TRUE) | ||
| expect_data_table(tab) | ||
| expect_names(names(tab), disjunct.from = "data_extra") | ||
| }) |
There was a problem hiding this comment.
are there any interesting cases where workhorse() is executed in a different (parallelization cluster) process that might be interesting here that should be tested?
|
Callbacks will behave differently depending on the parallelization. task = tsk("pima")
learner = lrn("classif.rpart")
resampling = rsmp("cv", folds = 3)
callback = callback_evaluation("test",
on_evaluation_begin = function(callback, context) {
if (context$iteration == 1) context$task$select(c("age", "insulin"))
}
)
rr = resample(task, learner, resampling, callbacks = callback)
rr$learners[[1]]$state$feature_names
# > [1] "age" "insulin"
rr$learners[[2]]$state$feature_names
# > [1] "age" "insulin"
with_future("multisession", {
rr = resample(task, learner, resampling, callbacks = callback)
})
rr$learners[[1]]$state$feature_names
# > [1] "age" "insulin"
rr$learners[[2]]$state$feature_names
# > [1] "age" "glucose" "insulin" "mass" "pedigree" "pregnant" "pressure" "triceps"I think we should not clone these objects to get a consistent behavior. This will add unnecessary overhead. This is now documented in |
|
Use cases:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional overhead is less than 3% when using 10ms models